qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/7] raspi: add BCM2835 SOC MPHI emulation


From: Peter Maydell
Subject: Re: [PATCH v5 1/7] raspi: add BCM2835 SOC MPHI emulation
Date: Mon, 18 May 2020 16:14:59 +0100

On Tue, 12 May 2020 at 07:49, Paul Zimmerman <address@hidden> wrote:
>
> Add BCM2835 SOC MPHI (Message-based Parallel Host Interface)
> emulation. It is very basic, only providing the FIQ interrupt
> needed to allow the dwc-otg USB host controller driver in the
> Raspbian kernel to function.
>
> Signed-off-by: Paul Zimmerman <address@hidden>


> +static void mphi_reset(DeviceState *dev)
> +{
> +}

Surely we need to actually reset the device state fields here?

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]