Re: [PULL 00/31] target-arm queue

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 00/31] target-arm queue
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cc6c93a hw/arm: xlnx-zcu102: Disable unsupported FDT firmware nodes
851a774 hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102
cb4770a device_tree: Constify compat in qemu_fdt_node_path()
a26ed36 device_tree: Allow name wildcards in qemu_fdt_node_path()
0c7b245 target/arm/cpu: Update coding style to make checkpatch.pl happy
6e87116 target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]
ac5d9f2 target/arm: Make cpu_register() available for other files
1f8dbd1 target/arm: Restrict the Address Translate write operation to TCG accel
26c5aa2 hw/arm/virt: dt: add kaslr-seed property
256d88c hw/arm/virt: dt: move creation of /secure-chosen to create_fdt()
281ba0a target/arm: Vectorize integer comparison vs zero
d335551 net: cadence_gem: clear RX control descriptor
886d104 Cadence: gem: fix wraparound in 64bit descriptors
adab3ff hw/arm: versal: Setup the ADMA with 128bit bus-width
9ff65f3 qdev-monitor: print the device's clock with info qtree
ea507fb hw/arm/xilinx_zynq: connect uart clocks to slcr
abd4b39 hw/char/cadence_uart: add clock support
02a7d87 hw/misc/zynq_slcr: add clock generation for uarts
947bc22 docs/clocks: add device's clock documentation
49f9409 qdev-clock: introduce an init array to ease the device construction
6b7b97c qdev: add clock input&output support to devices.
62643a6 hw/core/clock-vmstate: define a vmstate entry for clock state
d7158be hw/core/clock: introduce clock object
de7c1af tests/boot_linux_console: Add ethernet test to SmartFusion2
2dd76b4 msf2: Add EMAC block to SmartFusion2 SoC
bf46971 hw/net: Add Smartfusion2 emac block
0af4051 Typo: Correct the name of CPU hotplug memory region
fb7f6b0 bugfix: Use gicr_typer in arm_gicv3_icc_reset
95a592a nrf51: Fix last GPIO CNF address
00478e2 dma/xlnx-zdma: Fix descriptor loading (REG) wrt endianness
7fec387 dma/xlnx-zdma: Fix descriptor loading (MEM) wrt endianness

=== OUTPUT BEGIN ===
1/31 Checking commit 7fec38768f4a (dma/xlnx-zdma: Fix descriptor loading (MEM) 
wrt endianness)
2/31 Checking commit 00478e21e556 (dma/xlnx-zdma: Fix descriptor loading (REG) 
wrt endianness)
3/31 Checking commit 95a592a9ca01 (nrf51: Fix last GPIO CNF address)
4/31 Checking commit fb7f6b03b3bd (bugfix: Use gicr_typer in 
arm_gicv3_icc_reset)
5/31 Checking commit 0af4051edd5b (Typo: Correct the name of CPU hotplug memory 
region)
6/31 Checking commit bf46971ba6f8 (hw/net: Add Smartfusion2 emac block)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 654 lines checked

Patch 6/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/31 Checking commit 2dd76b4a530d (msf2: Add EMAC block to SmartFusion2 SoC)
8/31 Checking commit de7c1af6c5fa (tests/boot_linux_console: Add ethernet test 
to SmartFusion2)
9/31 Checking commit d7158be1a4b6 (hw/core/clock: introduce clock object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 363 lines checked

Patch 9/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/31 Checking commit 62643a6e45ee (hw/core/clock-vmstate: define a vmstate 
entry for clock state)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 10/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/31 Checking commit 6b7b97c06fc4 (qdev: add clock input&output support to 
devices.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

total: 0 errors, 1 warnings, 353 lines checked

Patch 11/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/31 Checking commit 49f9409e6aba (qdev-clock: introduce an init array to ease 
the device construction)
13/31 Checking commit 947bc2295320 (docs/clocks: add device's clock 
documentation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 395 lines checked

Patch 13/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/31 Checking commit 02a7d875317b (hw/misc/zynq_slcr: add clock generation for 
uarts)
15/31 Checking commit abd4b39e45cc (hw/char/cadence_uart: add clock support)
16/31 Checking commit ea507fb82a69 (hw/arm/xilinx_zynq: connect uart clocks to 
slcr)
17/31 Checking commit 9ff65f39fc29 (qdev-monitor: print the device's clock with 
info qtree)
18/31 Checking commit adab3ff8d273 (hw/arm: versal: Setup the ADMA with 128bit 
bus-width)
19/31 Checking commit 886d104dd971 (Cadence: gem: fix wraparound in 64bit 
descriptors)
20/31 Checking commit d335551dccc5 (net: cadence_gem: clear RX control 
descriptor)
21/31 Checking commit 281ba0a4e829 (target/arm: Vectorize integer comparison vs 
zero)
ERROR: spaces required around that '==' (ctx:WxB)
#529: FILE: target/arm/vec_helper.c:1272:
+DO_CMP0(gvec_ceq0_b, int8_t, ==)
                              ^

ERROR: spaces required around that '<' (ctx:WxB)
#530: FILE: target/arm/vec_helper.c:1273:
+DO_CMP0(gvec_clt0_b, int8_t, <)
                              ^

ERROR: spaces required around that '<=' (ctx:WxB)
#531: FILE: target/arm/vec_helper.c:1274:
+DO_CMP0(gvec_cle0_b, int8_t, <=)
                              ^

ERROR: spaces required around that '>' (ctx:WxB)
#532: FILE: target/arm/vec_helper.c:1275:
+DO_CMP0(gvec_cgt0_b, int8_t, >)
                              ^

ERROR: spaces required around that '>=' (ctx:WxB)
#533: FILE: target/arm/vec_helper.c:1276:
+DO_CMP0(gvec_cge0_b, int8_t, >=)
                              ^

ERROR: spaces required around that '==' (ctx:WxB)
#535: FILE: target/arm/vec_helper.c:1278:
+DO_CMP0(gvec_ceq0_h, int16_t, ==)
                               ^

ERROR: spaces required around that '<' (ctx:WxB)
#536: FILE: target/arm/vec_helper.c:1279:
+DO_CMP0(gvec_clt0_h, int16_t, <)
                               ^

ERROR: spaces required around that '<=' (ctx:WxB)
#537: FILE: target/arm/vec_helper.c:1280:
+DO_CMP0(gvec_cle0_h, int16_t, <=)
                               ^

ERROR: spaces required around that '>' (ctx:WxB)
#538: FILE: target/arm/vec_helper.c:1281:
+DO_CMP0(gvec_cgt0_h, int16_t, >)
                               ^

ERROR: spaces required around that '>=' (ctx:WxB)
#539: FILE: target/arm/vec_helper.c:1282:
+DO_CMP0(gvec_cge0_h, int16_t, >=)
                               ^

total: 10 errors, 0 warnings, 488 lines checked

Patch 21/31 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/31 Checking commit 256d88c8ec50 (hw/arm/virt: dt: move creation of 
/secure-chosen to create_fdt())
23/31 Checking commit 26c5aa2e8033 (hw/arm/virt: dt: add kaslr-seed property)
24/31 Checking commit 1f8dbd12050f (target/arm: Restrict the Address Translate 
write operation to TCG accel)
25/31 Checking commit ac5d9f2b0eab (target/arm: Make cpu_register() available 
for other files)
26/31 Checking commit 6e87116ad76d (target/arm/cpu: Use ARRAY_SIZE() to iterate 
over ARMCPUInfo[])
27/31 Checking commit 0c7b245988d9 (target/arm/cpu: Update coding style to make 
checkpatch.pl happy)
28/31 Checking commit a26ed36615e1 (device_tree: Allow name wildcards in 
qemu_fdt_node_path())
29/31 Checking commit cb4770a86c1d (device_tree: Constify compat in 
qemu_fdt_node_path())
30/31 Checking commit 851a7747ead2 (hw/arm: xlnx-zcu102: Move arm_boot_info 
into XlnxZCU102)
31/31 Checking commit cc6c93a4b886 (hw/arm: xlnx-zcu102: Disable unsupported 
FDT firmware nodes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden