qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 27/31] target/arm/cpu: Update coding style to make checkpatch.


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 27/31] target/arm/cpu: Update coding style to make checkpatch.pl happy
Date: Thu, 30 Apr 2020 16:52:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/30/20 1:51 PM, Peter Maydell wrote:
From: Philippe Mathieu-Daudé <address@hidden>

We will move this code in the next commit. Clean it up
first to avoid checkpatch.pl errors.

Oops this isn't the next commit anymore :S


Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
---
  target/arm/cpu.c | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 30e961f7754..a1e38b38ba1 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -582,7 +582,8 @@ static bool arm_v7m_cpu_exec_interrupt(CPUState *cs, int 
interrupt_request)
      CPUARMState *env = &cpu->env;
      bool ret = false;
- /* ARMv7-M interrupt masking works differently than -A or -R.
+    /*
+     * ARMv7-M interrupt masking works differently than -A or -R.
       * There is no FIQ/IRQ distinction. Instead of I and F bits
       * masking FIQ and IRQ interrupts, an exception is taken only
       * if it is higher priority than the current execution priority
@@ -1912,7 +1913,8 @@ static void arm1026_initfn(Object *obj)
  static void arm1136_r2_initfn(Object *obj)
  {
      ARMCPU *cpu = ARM_CPU(obj);
-    /* What qemu calls "arm1136_r2" is actually the 1136 r0p2, ie an
+    /*
+     * What qemu calls "arm1136_r2" is actually the 1136 r0p2, ie an
       * older core than plain "arm1136". In particular this does not
       * have the v6K features.
       * These ID register values are correct for 1136 but may be wrong
@@ -2698,7 +2700,8 @@ static const ARMCPUInfo arm_cpus[] = {
      { .name = "arm926",      .initfn = arm926_initfn },
      { .name = "arm946",      .initfn = arm946_initfn },
      { .name = "arm1026",     .initfn = arm1026_initfn },
-    /* What QEMU calls "arm1136-r2" is actually the 1136 r0p2, i.e. an
+    /*
+     * What QEMU calls "arm1136-r2" is actually the 1136 r0p2, i.e. an
       * older core than plain "arm1136". In particular this does not
       * have the v6K features.
       */





reply via email to

[Prev in Thread] Current Thread [Next in Thread]