[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac()
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler |
|
Date: |
Sun, 15 Mar 2020 14:25:33 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/13/20 11:45 AM, Philippe Mathieu-Daudé wrote:
> + if (qemu_strtol(str + pos, &p, 16, &val) < 0 || val > 0xff) {
> + goto inval;
> + }
This is doing more that *just* using qemu_strtol, it's also validating the
input. I don't think you need to adjust the patch, just improve the commit
message. With that,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH 0/9] user-mode: Prune build dependencies (part 3), Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 2/9] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr(), Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 3/9] hw/core/qdev-properties: Fix code style, Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 4/9] hw/core/qdev-properties: Export enum-related functions, Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler, Philippe Mathieu-Daudé, 2020/03/13
- Re: [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler,
Richard Henderson <=
- [PATCH 5/9] hw/core/qdev-properties: Export qdev_prop_enum, Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 6/9] hw/core/qdev-properties: Export some integer-related functions, Philippe Mathieu-Daudé, 2020/03/13
- [PATCH 8/9] hw/core: Add qdev stub for user-mode, Philippe Mathieu-Daudé, 2020/03/13