[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode |
Date: |
Sat, 14 Mar 2020 11:57:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 14/03/20 11:49, Philippe Mathieu-Daudé wrote:
>>>
>>> diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
>>> index 6215e7c208..89bf247173 100644
>>> --- a/hw/core/Makefile.objs
>>> +++ b/hw/core/Makefile.objs
>>> @@ -8,6 +8,7 @@ common-obj-y += vmstate-if.o
>>> # irq.o needed for qdev GPIO handling:
>>> common-obj-y += irq.o
>>> +common-obj-$(call lnot,$(CONFIG_SOFTMMU)) += qdev-stubs.o
>>
>> This should be:
>>
>> obj-$(call lnot,$(CONFIG_SOFTMMU)) += qdev-stubs.o
>
> Actually I moved it to stub-obj-y which makes things easier.
No, common-obj- is the right thing, followed by
common-obj-$(CONFIG_ALL) += qdev-stubs.o
Paolo
- [PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler, (continued)
[PATCH 7/9] hw/core/qdev-properties: Extract system-mode specific properties, Philippe Mathieu-Daudé, 2020/03/13
[PATCH 9/9] qapi: Restrict code generated for user-mode, Philippe Mathieu-Daudé, 2020/03/13
Re: [PATCH 0/9] user-mode: Prune build dependencies (part 3), no-reply, 2020/03/15
Re: [PATCH 0/9] user-mode: Prune build dependencies (part 3), no-reply, 2020/03/15