Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode

[Philippe Mathieu-Daudé]

On 3/14/20 11:57 AM, Paolo Bonzini wrote:
> On 14/03/20 11:49, Philippe Mathieu-Daudé wrote:
> > > > diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
> > > > index 6215e7c208..89bf247173 100644
> > > > --- a/hw/core/Makefile.objs
> > > > +++ b/hw/core/Makefile.objs
> > > > @@ -8,6 +8,7 @@ common-obj-y += vmstate-if.o
> > > >    # irq.o needed for qdev GPIO handling:
> > > >    common-obj-y += irq.o
> > > > +common-obj-$(call lnot,$(CONFIG_SOFTMMU)) += qdev-stubs.o
> > >
> > > This should be:
> > >
> > >      obj-$(call lnot,$(CONFIG_SOFTMMU)) += qdev-stubs.o
> >
> > Actually I moved it to stub-obj-y which makes things easier.
>
> No, common-obj- is the right thing, followed by
>
> common-obj-$(CONFIG_ALL) += qdev-stubs.o

I don't understand CONFIG_ALL magic, why is that different to common-obj-y?

Anyway your suggestion works, so I'll blindly use it, thanks.

> Paolo