Re: [PATCH v2 1/3] hw/usb: Add basic i.MX USB Phy support

[Peter Maydell]

On Tue, 10 Mar 2020 at 21:04, Guenter Roeck <address@hidden> wrote:
>
> Add basic USB PHY support as implemented in i.MX23, i.MX28, i.MX6,
> and i.MX7 SoCs.
>
> The only support really needed - at least to boot Linux - is support
> for soft reset, which needs to reset various registers to their initial
> value. Otherwise, just record register values.
>
> Signed-off-by: Guenter Roeck <address@hidden>
> ---
> v2: New patch, replacing dummy STMP register support with basic USB PHY
>     emulation.
>
>  hw/arm/Kconfig               |   1 +
>  hw/usb/Kconfig               |   5 +
>  hw/usb/Makefile.objs         |   2 +
>  hw/usb/imx-usb-phy.c         | 225 +++++++++++++++++++++++++++++++++++
>  include/hw/usb/imx-usb-phy.h |  53 +++++++++
>  5 files changed, 286 insertions(+)
>  create mode 100644 hw/usb/imx-usb-phy.c
>  create mode 100644 include/hw/usb/imx-usb-phy.h


> +        /*
> +         * All REG_NAME_SET register access are in fact targeting the
> +         * the REG_NAME register.
> +         */

All these comments have a duplicate word: "the the".

You should add the new files to MAINTAINERS:

diff --git a/MAINTAINERS b/MAINTAINERS
index 857f969aa1f..4e42187aafb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -748,6 +748,8 @@ F: hw/arm/sabrelite.c
 F: hw/arm/fsl-imx6.c
 F: hw/misc/imx6_*.c
 F: hw/ssi/imx_spi.c
+F: hw/usb/imx-usb-phy.c
+F: include/hw/usb/imx-usb-phy.h
 F: include/hw/arm/fsl-imx6.h
 F: include/hw/misc/imx6_*.h
 F: include/hw/ssi/imx_spi.h

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM