Re: [PATCH 0/4] usb-serial: xHCI and timeout fixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/4] usb-serial: xHCI and timeout fixes
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
657eee3 usb-serial: Fix timeout closing the device
299ce37 usb-serial: Increase receive buffer to 496
80411e3 usb-serial: chunk data to wMaxPacketSize
1d93326 usb-serial: Move USB_TOKEN_IN into a helper function

=== OUTPUT BEGIN ===
1/4 Checking commit 1d9332671a0d (usb-serial: Move USB_TOKEN_IN into a helper 
function)
ERROR: braces {} are necessary for all arms of this statement
#44: FILE: hw/usb/dev-serial.c:384:
+    if (len > s->recv_used)
[...]

ERROR: braces {} are necessary for all arms of this statement
#50: FILE: hw/usb/dev-serial.c:390:
+    if (first_len > len)
[...]

ERROR: braces {} are necessary for all arms of this statement
#54: FILE: hw/usb/dev-serial.c:394:
+    if (len > first_len)
[...]

total: 3 errors, 0 warnings, 94 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 80411e3c7e85 (usb-serial: chunk data to wMaxPacketSize)
ERROR: braces {} are necessary for all arms of this statement
#80: FILE: hw/usb/dev-serial.c:395:
+        if (len > s->recv_used)
[...]

ERROR: braces {} are necessary for all arms of this statement
#84: FILE: hw/usb/dev-serial.c:399:
+        if (first_len > len)
[...]

ERROR: braces {} are necessary for all arms of this statement
#88: FILE: hw/usb/dev-serial.c:403:
+        if (len > first_len)
[...]

total: 3 errors, 0 warnings, 63 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit 299ce37a1f63 (usb-serial: Increase receive buffer to 496)
4/4 Checking commit 657eee3ce83f (usb-serial: Fix timeout closing the device)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden