Re: [PATCH v2 3/3] hw/arm/fsl-imx6: Wire up USB controllers

[Peter Maydell]

On Tue, 10 Mar 2020 at 21:04, Guenter Roeck <address@hidden> wrote:
>
> With this patch, the USB controllers on 'sabrelite' are detected
> and can be used to boot the system.
>
> Signed-off-by: Guenter Roeck <address@hidden>

> +    for (i = 0; i < FSL_IMX6_NUM_USBS; i++) {
> +        static const int FSL_IMX6_USBn_IRQ[] = {
> +            FSL_IMX6_USB_OTG_IRQ,
> +            FSL_IMX6_USB_HOST1_IRQ,
> +            FSL_IMX6_USB_HOST2_IRQ,
> +            FSL_IMX6_USB_HOST3_IRQ,
> +        };
> +
> +        object_property_set_bool(OBJECT(&s->usbphy[i]), true, "realized",
> +                                 &error_abort);
> +        sysbus_mmio_map(SYS_BUS_DEVICE(&s->usbphy[i]), 0,
> +                        FSL_IMX6_USBPHY1_ADDR + i * 0x1000);

Are you sure these addresses are right? Four of these starting
at USBPHY1_ADDR means the last one clashes with what we define
as "FSL_IMX6_SNVSHP_ADDR 0x020CC000".

I only have the i.MX 6Dual/6Quad reference manual to hand,
so maybe this imx6 variant is different, but that document
says there are 4 USB controllers but only 2 PHY blocks.

thanks
-- PMM