[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/7] hw/arm/exynos4210: Fix DMA initialization

From: Peter Maydell
Subject: Re: [PATCH v2 2/7] hw/arm/exynos4210: Fix DMA initialization
Date: Mon, 20 Jan 2020 14:46:16 +0000

On Mon, 20 Jan 2020 at 14:30, Guenter Roeck <address@hidden> wrote:
> On 1/20/20 5:35 AM, Peter Maydell wrote:
> > As the comment in or-irq.h notes, we can safely simply bump the
> > #define value without breaking anything if you need more input
> > OR lines than 32.
> >
> Yes, I noticed the comment, and I did that initially, but then
> I noticed the complexity of actually doing it in the code
> increasing it from 16 to 32, and decided I better leave it alone.

Yeah, the conversion from 16 to 32 was hairy because our
initial implementation made the migration-compatibility
awkward. When I wrote that conversion I was careful to
avoid creating a similar problem for my future self if
I needed to bump the value again :-)

> I'll add another patch fixing the check and use 32.

I just sent a patch that fixes the check.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]