[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/7] hw/arm/exynos4210: Fix DMA initialization

From: Guenter Roeck
Subject: Re: [PATCH v2 2/7] hw/arm/exynos4210: Fix DMA initialization
Date: Mon, 20 Jan 2020 06:30:29 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/20/20 5:35 AM, Peter Maydell wrote:
On Sat, 18 Jan 2020 at 16:42, Guenter Roeck <address@hidden> wrote:
[ ... ]
v2: Use interrupt combiner instead of connecting all events to a
     single interrupt. Limit number of events per DMA channel
     to 31 to meet qemu interrupt combiner limitations.
     [Not sure if "assert(s->num_lines < MAX_OR_LINES);" should be
      "assert(s->num_lines <= MAX_OR_LINES);"]

Yes, that looks like a bug in or-irq.c -- it should be using <=,
so 32 is permissible.

As the comment in or-irq.h notes, we can safely simply bump the
#define value without breaking anything if you need more input
OR lines than 32.

Yes, I noticed the comment, and I did that initially, but then
I noticed the complexity of actually doing it in the code
increasing it from 16 to 32, and decided I better leave it alone.
I'll add another patch fixing the check and use 32.

Reviewed-by: Peter Maydell <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]