[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 19/27] qcow2: Add subcluster support to expand_zero_cluste
From: |
Alberto Garcia |
Subject: |
[RFC PATCH v3 19/27] qcow2: Add subcluster support to expand_zero_clusters_in_l1() |
Date: |
Sun, 22 Dec 2019 12:37:00 +0100 |
Two changes are needed in order to add subcluster support to this
function: deallocated clusters must have their bitmaps cleared, and
expanded clusters must have all the "subcluster allocated" bits set.
Signed-off-by: Alberto Garcia <address@hidden>
---
block/qcow2-cluster.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 207f670c94..ede75138d2 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -2054,6 +2054,9 @@ static int expand_zero_clusters_in_l1(BlockDriverState
*bs, uint64_t *l1_table,
/* not backed; therefore we can simply deallocate the
* cluster */
set_l2_entry(s, l2_slice, j, 0);
+ if (has_subclusters(s)) {
+ set_l2_bitmap(s, l2_slice, j, 0);
+ }
l2_dirty = true;
continue;
}
@@ -2120,6 +2123,9 @@ static int expand_zero_clusters_in_l1(BlockDriverState
*bs, uint64_t *l1_table,
} else {
set_l2_entry(s, l2_slice, j, offset);
}
+ if (has_subclusters(s)) {
+ set_l2_bitmap(s, l2_slice, j, QCOW_L2_BITMAP_ALL_ALLOC);
+ }
l2_dirty = true;
}
--
2.20.1
- [RFC PATCH v3 24/27] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only, (continued)
- [RFC PATCH v3 24/27] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 11/27] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 18/27] qcow2: Add subcluster support to check_refcounts_l2(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extended L2 entries, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 17/27] qcow2: Add subcluster support to discard_in_l2_slice(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 10/27] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 03/27] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 22/27] qcow2: Clear the L2 bitmap when allocating a compressed cluster, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 08/27] qcow2: Add offset_to_sc_index(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 19/27] qcow2: Add subcluster support to expand_zero_clusters_in_l1(),
Alberto Garcia <=
- [RFC PATCH v3 21/27] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 06/27] qcow2: Add dummy has_subclusters() function, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 02/27] qcow2: Split cluster_needs_cow() out of count_cow_clusters(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 13/27] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 15/27] qcow2: Add subcluster support to qcow2_get_cluster_offset(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 20/27] qcow2: Fix offset calculation in handle_dependencies(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 23/27] qcow2: Add subcluster support to handle_alloc_space(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 09/27] qcow2: Add l2_entry_size(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 12/27] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_*, Alberto Garcia, 2019/12/22