[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 20/27] qcow2: Fix offset calculation in handle_dependencie
From: |
Alberto Garcia |
Subject: |
[RFC PATCH v3 20/27] qcow2: Fix offset calculation in handle_dependencies() |
Date: |
Sun, 22 Dec 2019 12:37:01 +0100 |
l2meta_cow_start() and l2meta_cow_end() are not necessarily
cluster-aligned if the image has subclusters, so update the
calculation of old_start and old_end to guarantee that no two requests
try to write on the same cluster.
Signed-off-by: Alberto Garcia <address@hidden>
---
block/qcow2-cluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index ede75138d2..0a40944667 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1279,8 +1279,8 @@ static int handle_dependencies(BlockDriverState *bs,
uint64_t guest_offset,
uint64_t start = guest_offset;
uint64_t end = start + bytes;
- uint64_t old_start = l2meta_cow_start(old_alloc);
- uint64_t old_end = l2meta_cow_end(old_alloc);
+ uint64_t old_start = start_of_cluster(s, l2meta_cow_start(old_alloc));
+ uint64_t old_end = ROUND_UP(l2meta_cow_end(old_alloc),
s->cluster_size);
if (end <= old_start || start >= old_end) {
/* No intersection */
--
2.20.1
- [RFC PATCH v3 10/27] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap(), (continued)
- [RFC PATCH v3 10/27] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 03/27] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 22/27] qcow2: Clear the L2 bitmap when allocating a compressed cluster, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 08/27] qcow2: Add offset_to_sc_index(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 19/27] qcow2: Add subcluster support to expand_zero_clusters_in_l1(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 21/27] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 06/27] qcow2: Add dummy has_subclusters() function, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 02/27] qcow2: Split cluster_needs_cow() out of count_cow_clusters(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 13/27] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 15/27] qcow2: Add subcluster support to qcow2_get_cluster_offset(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 20/27] qcow2: Fix offset calculation in handle_dependencies(),
Alberto Garcia <=
- [RFC PATCH v3 23/27] qcow2: Add subcluster support to handle_alloc_space(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 05/27] qcow2: Document the Extended L2 Entries feature, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 09/27] qcow2: Add l2_entry_size(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 12/27] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_*, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 26/27] qcow2: Add subcluster support to qcow2_measure(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 14/27] qcow2: Add subcluster support to calculate_l2_meta(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 04/27] qcow2: Add get_l2_entry() and set_l2_entry(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 25/27] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit, Alberto Garcia, 2019/12/22