[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 24/27] qcow2: Restrict qcow2_co_pwrite_zeroes() to full cl
From: |
Alberto Garcia |
Subject: |
[RFC PATCH v3 24/27] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only |
Date: |
Sun, 22 Dec 2019 12:37:05 +0100 |
Ideally it should be possible to zero individual subclusters using
this function, but this is currently not implemented.
Signed-off-by: Alberto Garcia <address@hidden>
---
block/qcow2.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 242001afa2..0267722065 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3754,6 +3754,12 @@ static coroutine_fn int
qcow2_co_pwrite_zeroes(BlockDriverState *bs,
qemu_co_mutex_unlock(&s->lock);
return -ENOTSUP;
}
+ /* TODO: allow zeroing separate subclusters, we only allow
+ * zeroing full clusters at the moment. */
+ if (nr != bytes) {
+ qemu_co_mutex_unlock(&s->lock);
+ return -ENOTSUP;
+ }
if (type != QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN &&
type != QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC &&
type != QCOW2_SUBCLUSTER_ZERO_PLAIN &&
--
2.20.1
- [RFC PATCH v3 00/27] Add subcluster allocation to qcow2, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 16/27] qcow2: Add subcluster support to zero_in_l2_slice(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 01/27] qcow2: Add calculate_l2_meta(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 24/27] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only,
Alberto Garcia <=
- [RFC PATCH v3 11/27] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 18/27] qcow2: Add subcluster support to check_refcounts_l2(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extended L2 entries, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 17/27] qcow2: Add subcluster support to discard_in_l2_slice(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 10/27] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 03/27] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 22/27] qcow2: Clear the L2 bitmap when allocating a compressed cluster, Alberto Garcia, 2019/12/22
- [RFC PATCH v3 08/27] qcow2: Add offset_to_sc_index(), Alberto Garcia, 2019/12/22
- [RFC PATCH v3 19/27] qcow2: Add subcluster support to expand_zero_clusters_in_l1(), Alberto Garcia, 2019/12/22