[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 26/40] target/arm: Update define_one_arm_cp_reg_with_opaqu
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v4 26/40] target/arm: Update define_one_arm_cp_reg_with_opaque for VHE |
|
Date: |
Fri, 6 Dec 2019 15:53:59 +0000 |
On Tue, 3 Dec 2019 at 02:30, Richard Henderson
<address@hidden> wrote:
>
> For ARMv8.1, op1 == 5 is reserved for EL2 aliases of
> EL1 and EL0 registers.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/helper.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 023b8963cf..1812588fa1 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -7437,13 +7437,10 @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
> mask = PL0_RW;
> break;
> case 4:
> + case 5:
> /* min_EL EL2 */
> mask = PL2_RW;
> break;
> - case 5:
> - /* unallocated encoding, so not possible */
> - assert(false);
> - break;
> case 6:
> /* min_EL EL3 */
> mask = PL3_RW;
> --
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [PATCH v4 14/40] target/arm: Recover 4 bits from TBFLAGs, (continued)
[PATCH v4 16/40] target/arm: Rearrange ARMMMUIdxBit, Richard Henderson, 2019/12/02
[PATCH v4 26/40] target/arm: Update define_one_arm_cp_reg_with_opaque for VHE, Richard Henderson, 2019/12/02
Re: [PATCH v4 26/40] target/arm: Update define_one_arm_cp_reg_with_opaque for VHE,
Peter Maydell <=
[PATCH v4 21/40] target/arm: Update arm_sctlr for VHE, Richard Henderson, 2019/12/02
[PATCH v4 20/40] target/arm: Update arm_mmu_idx for VHE, Richard Henderson, 2019/12/02
[PATCH v4 23/40] target/arm: Update ctr_el0_access for EL2, Richard Henderson, 2019/12/02
[PATCH v4 15/40] target/arm: Expand TBFLAG_ANY.MMUIDX to 4 bits, Richard Henderson, 2019/12/02
[PATCH v4 17/40] target/arm: Tidy ARMMMUIdx m-profile definitions, Richard Henderson, 2019/12/02
[PATCH v4 19/40] target/arm: Add regime_has_2_ranges, Richard Henderson, 2019/12/02