[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 08/13] tb-stats: reset the tracked TBs on a tb_flush
From: |
Richard Henderson |
Subject: |
Re: [PATCH v9 08/13] tb-stats: reset the tracked TBs on a tb_flush |
Date: |
Tue, 8 Oct 2019 14:00:18 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 10/7/19 11:28 AM, Alex Bennée wrote:
> We keep track of translations but can only do so up until the
> translation cache is flushed. At that point we really have no idea if
> we can re-create a translation because all the active tracking
> information has been reset.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> accel/tcg/tb-stats.c | 19 +++++++++++++++++++
> accel/tcg/translate-all.c | 2 +-
> include/exec/tb-stats.h | 8 ++++++++
> 3 files changed, 28 insertions(+), 1 deletion(-)
I still don't understand what the tbs array is for,
but resetting it at flush is fine.
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v9 01/13] accel/tcg: introduce TBStatistics structure, (continued)
- [PATCH v9 01/13] accel/tcg: introduce TBStatistics structure, Alex Bennée, 2019/10/07
- [PATCH v9 06/13] debug: add -d tb_stats to control TBStatistics collection:, Alex Bennée, 2019/10/07
- [PATCH v9 07/13] monitor: adding tb_stats hmp command, Alex Bennée, 2019/10/07
- [PATCH v9 04/13] accel: replacing part of CONFIG_PROFILER with TBStats, Alex Bennée, 2019/10/07
- [PATCH v9 08/13] tb-stats: reset the tracked TBs on a tb_flush, Alex Bennée, 2019/10/07
- Re: [PATCH v9 08/13] tb-stats: reset the tracked TBs on a tb_flush,
Richard Henderson <=
- [PATCH v9 10/13] tb-stats: dump hot TBs at the end of the execution, Alex Bennée, 2019/10/07
- [PATCH v9 05/13] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER, Alex Bennée, 2019/10/07
- [PATCH v9 12/13] tb-stats: adding TBStatistics info into perf dump, Alex Bennée, 2019/10/07
- [PATCH v9 13/13] configure: remove the final bits of --profiler support, Alex Bennée, 2019/10/07
- [PATCH v9 09/13] Adding info [tb-list|tb] commands to HMP (WIP), Alex Bennée, 2019/10/07