[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] migration: pass in_postcopy instead of check state again
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 3/4] migration: pass in_postcopy instead of check state again |
Date: |
Tue, 8 Oct 2019 18:57:18 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Wei Yang (address@hidden) wrote:
> Not necessary to do the check again.
>
> Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index c8eaa85867..56031305e3 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3148,8 +3148,7 @@ static MigIterateState
> migration_iteration_run(MigrationState *s)
> return MIG_ITERATE_SKIP;
> }
> /* Just another iteration step */
> - qemu_savevm_state_iterate(s->to_dst_file,
> - s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE);
> + qemu_savevm_state_iterate(s->to_dst_file, in_postcopy);
> } else {
> trace_migration_thread_low_pending(pending_size);
> migration_completion(s);
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PATCH 0/4] migration: trivial cleanup and refine, Wei Yang, 2019/10/05
- [PATCH 1/4] migration/ram: only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE, Wei Yang, 2019/10/05
- [PATCH 2/4] migration/postcopy: fix typo in mark_postcopy_blocktime_begin's comment, Wei Yang, 2019/10/05
- [PATCH 4/4] migration: report SaveStateEntry id and name on failure, Wei Yang, 2019/10/05
- [PATCH 3/4] migration: pass in_postcopy instead of check state again, Wei Yang, 2019/10/05
- Re: [PATCH 3/4] migration: pass in_postcopy instead of check state again,
Dr. David Alan Gilbert <=
- Re: [PATCH 0/4] migration: trivial cleanup and refine, Dr. David Alan Gilbert, 2019/10/11