Re: [PATCH v9 01/13] accel/tcg: introduce TBStatistics structure

[Richard Henderson]

On 10/7/19 11:28 AM, Alex Bennée wrote:
> From: "Vanderson M. do Rosario" <address@hidden>
> 
> To store statistics for each TB, we created a TBStatistics structure
> which is linked with the TBs. TBStatistics can stay alive after
> tb_flush and be relinked to a regenerated TB. So the statistics can
> be accumulated even through flushes.
> 
> The goal is to have all present and future qemu/tcg statistics and
> meta-data stored in this new structure.
> 
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Vanderson M. do Rosario <address@hidden>
> Message-Id: <address@hidden>
> [AJB: fix git author, review comments]
> Signed-off-by: Alex Bennée <address@hidden>
> 
> ---
> AJB
>   - move tcg_collect_tb_stats inside tb-stats.c
>   - add spdx header
>   - drop tb from tbstats and associated functions
> ---

The only quibble I have is with

> +void init_tb_stats_htable_if_not(void);

If not what?

I can only imagine that this phrase is intended to finish "if not initialized".
 But I think it's clearer to just call this "init_tb_stats_htable".

> +void enable_collect_tb_stats(void)
> +{
> +    init_tb_stats_htable_if_not();

Why do we need to do this again, since we did this in tb_htable_init?


r~