[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path |
Date: |
Wed, 17 Jul 2019 07:24:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 7/16/19 11:06 PM, address@hidden wrote:
> +++ b/include/exec/poison.h
> @@ -38,7 +38,6 @@
> #pragma GCC poison TARGET_HAS_BFLT
> #pragma GCC poison TARGET_NAME
> #pragma GCC poison TARGET_SUPPORTS_MTTCG
> -#pragma GCC poison TARGET_WORDS_BIGENDIAN
You can't do this. This is here for a very good reason, to avoid letting
target-specific values creep into code that is compiled once, for all targets.
This means that you'll need to either move MO_TE out of memop.h or perhaps
conditionalize it upon NEED_CPU_H.
I would like to see this patch broken up into smaller bits. Convert one
interface at a time, pushing the use of MemOp further down the stack. At
present it's hard to review.
r~
- [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE, tony.nguyen, 2019/07/17
- [Qemu-devel] [PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp, tony.nguyen, 2019/07/17
- [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path, tony.nguyen, 2019/07/17
- [Qemu-devel] [PATCH 4/4] target/sparc: sun4u Invert Endian TTE bit, tony.nguyen, 2019/07/17
- [Qemu-devel] [PATCH 3/4] cputlb: Byte swap memory transaction attribute, tony.nguyen, 2019/07/17
- Re: [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE, Paolo Bonzini, 2019/07/17