qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] tcg: TCGMemOp is now accelerator independen


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp
Date: Wed, 17 Jul 2019 07:04:17 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 7/16/19 11:04 PM, address@hidden wrote:
> +    MO_ASHIFT = 4,
> +    MO_AMASK = 7 << MO_ASHIFT,
> +#ifdef ALIGNED_ONLY
> +    MO_ALIGN = 0,
> +    MO_UNALN = MO_AMASK,
> +#else
> +    MO_ALIGN = MO_AMASK,
> +    MO_UNALN = 0,
> +#endif

I'm not sure you can move this portion as-is.

I think ALIGNED_ONLY needs to be moved out of target/foo/cpu.h into configure,
as we do with TARGET_WORDS_BIGENDIAN, so that it's always defined early.  Also,
poison the symbol in include/exec/poison.h.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]