[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 19/19] vl: make sure char-pty message displayed by mo
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 19/19] vl: make sure char-pty message displayed by moving setbuf to the beginning |
Date: |
Tue, 16 Jul 2019 10:11:17 +0200 |
From: Wei Yang <address@hidden>
Recently we found a behavior change after commit 6ade45f2ac93611
('char-pty: Print "char device redirected" message to stdout').
When we redirect output to a file, the message "char device redirected
to PTY_NAME (label LABEL)" would not be seen at the beginning of the
file. Instead, the message is displayed after QEMU quit. This will block
test automation.
The reason is this message is printed after we set line buffer mode. So
move this to the beginning.
Signed-off-by: Wei Yang <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 5089fce..a5808f9 100644
--- a/vl.c
+++ b/vl.c
@@ -2890,6 +2890,8 @@ int main(int argc, char **argv, char **envp)
char *dir, **dirs;
BlockdevOptionsQueue bdo_queue = QSIMPLEQ_HEAD_INITIALIZER(bdo_queue);
+ os_set_line_buffering();
+
error_init(argv[0]);
module_call_init(MODULE_INIT_TRACE);
@@ -4246,8 +4248,6 @@ int main(int argc, char **argv, char **envp)
semihosting_arg_fallback(kernel_filename, kernel_cmdline);
}
- os_set_line_buffering();
-
/* spice needs the timers to be initialized by this point */
qemu_spice_init();
--
1.8.3.1
- Re: [Qemu-devel] [PULL 08/19] hw/i386: turn off vmport if CONFIG_VMPORT is disabled, (continued)
- [Qemu-devel] [PULL 09/19] memory: unref the memory region in simplify flatview, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 10/19] Fix broken build with WHPX enabled, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 11/19] util: merge main-loop.c and iohandler.c, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 12/19] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 14/19] target/i386: sev: Do not unpin ram device memory region, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 15/19] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 16/19] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 13/19] checkpatch: detect doubly-encoded UTF-8, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 17/19] Makefile: do not repeat $(CONFIG_SOFTMMU) in hw/Makefile.objs, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 19/19] vl: make sure char-pty message displayed by moving setbuf to the beginning,
Paolo Bonzini <=
- [Qemu-devel] [PULL 18/19] create_config: remove $(CONFIG_SOFTMMU) hack, Paolo Bonzini, 2019/07/16
- Re: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16, no-reply, 2019/07/16
- Re: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16, Peter Maydell, 2019/07/16
- Re: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16, Peter Maydell, 2019/07/19