Re: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
db7c8bd vl: make sure char-pty message displayed by moving setbuf to the 
beginning
8f48c9a create_config: remove $(CONFIG_SOFTMMU) hack
ca11419 Makefile: do not repeat $(CONFIG_SOFTMMU) in hw/Makefile.objs
0131f11 hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI
fd8977c hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
1c7aad6 target/i386: sev: Do not unpin ram device memory region
6e17e8f checkpatch: detect doubly-encoded UTF-8
df73f94 hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller
0538f34 util: merge main-loop.c and iohandler.c
8112363 Fix broken build with WHPX enabled
9ac7907 memory: unref the memory region in simplify flatview
15913c5 hw/i386: turn off vmport if CONFIG_VMPORT is disabled
e97ff84 rdmacm-mux: fix strcpy string warning
41bec64 build-sys: remove slirp cflags from main-loop.o
bf28a5e iscsi: base all handling of check condition on scsi_sense_to_errno
ed55acf iscsi: fix busy/timeout/task set full
378b9f0 scsi: add guest-recoverable ZBC errors
0e2ded1 scsi: explicitly list guest-recoverable sense codes
6aaa445 scsi-disk: pass sense correctly for guest-recoverable errors

=== OUTPUT BEGIN ===
1/19 Checking commit 6aaa44542e0a (scsi-disk: pass sense correctly for 
guest-recoverable errors)
2/19 Checking commit 0e2ded152b3a (scsi: explicitly list guest-recoverable 
sense codes)
WARNING: line over 80 characters
#27: FILE: hw/scsi/scsi-disk.c:457:
+            if (scsi_sense_buf_is_guest_recoverable(r->req.sense, 
sizeof(r->req.sense))) {

WARNING: line over 80 characters
#45: FILE: include/scsi/utils.h:109:
+bool scsi_sense_buf_is_guest_recoverable(const uint8_t *sense, size_t 
sense_size);

total: 0 errors, 2 warnings, 78 lines checked

Patch 2/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/19 Checking commit 378b9f03db84 (scsi: add guest-recoverable ZBC errors)
4/19 Checking commit ed55acfce974 (iscsi: fix busy/timeout/task set full)
5/19 Checking commit bf28a5e8685d (iscsi: base all handling of check condition 
on scsi_sense_to_errno)
ERROR: return of an errno should typically be -ve (return -EAGAIN)
#88: FILE: scsi/utils.c:382:
+        return EAGAIN;

ERROR: return of an errno should typically be -ve (return -EINPROGRESS)
#97: FILE: scsi/utils.c:411:
+        return EINPROGRESS;

total: 2 errors, 0 warnings, 74 lines checked

Patch 5/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/19 Checking commit 41bec64cc2c7 (build-sys: remove slirp cflags from 
main-loop.o)
7/19 Checking commit e97ff84ebcfc (rdmacm-mux: fix strcpy string warning)
8/19 Checking commit 15913c50a392 (hw/i386: turn off vmport if CONFIG_VMPORT is 
disabled)
9/19 Checking commit 9ac79075636c (memory: unref the memory region in simplify 
flatview)
10/19 Checking commit 8112363187e0 (Fix broken build with WHPX enabled)
11/19 Checking commit 0538f34bd405 (util: merge main-loop.c and iohandler.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
deleted file mode 100644

WARNING: Block comments use a leading /* on a separate line
#237: FILE: util/main-loop.c:578:
+/* reaping of zombies.  right now we're not passing the status to

WARNING: Block comments use * on subsequent lines
#238: FILE: util/main-loop.c:579:
+/* reaping of zombies.  right now we're not passing the status to
+   anyone, but it would be possible to add a callback.  */

WARNING: Block comments use a trailing */ on a separate line
#238: FILE: util/main-loop.c:579:
+   anyone, but it would be possible to add a callback.  */

total: 0 errors, 4 warnings, 127 lines checked

Patch 11/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/19 Checking commit df73f94a7149 (hw/lm32/Kconfig: Milkymist One provides a 
USB 1.1 Controller)
13/19 Checking commit 6e17e8f7434a (checkpatch: detect doubly-encoded UTF-8)
WARNING: line over 80 characters
#35: FILE: scripts/checkpatch.pl:271:
+       | \xC3[\xA1-\xAC\xAE\xAF] (?: \xC2[\x80-\xBF]){2}  # e1-ec/ee/ef 80-bf 
80-bf

WARNING: line over 80 characters
#37: FILE: scripts/checkpatch.pl:273:
+       | \xC3\xB0 \xC2[\x90-\xBF] (?: \xC2[\x80-\xBF]){2} # f0 90-bf 80-bf 
80-bf

WARNING: line over 80 characters
#38: FILE: scripts/checkpatch.pl:274:
+       | \xC3[\xB1-\xB3] (?: \xC2[\x80-\xBF]){3}          # f1-f3 80-bf 80-bf 
80-bf

WARNING: line over 80 characters
#39: FILE: scripts/checkpatch.pl:275:
+       | \xC3\xB4 \xC2[\x80-\x8F] (?: \xC2[\x80-\xBF]){2} # f4 80-b8 80-bf 
80-bf

total: 0 errors, 4 warnings, 28 lines checked

Patch 13/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/19 Checking commit 1c7aad662155 (target/i386: sev: Do not unpin ram device 
memory region)
15/19 Checking commit fd8977ce486f (hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI)
16/19 Checking commit 0131f1107c96 (hw/usb/Kconfig: USB_XHCI_NEC requires 
USB_XHCI)
17/19 Checking commit ca1141992871 (Makefile: do not repeat $(CONFIG_SOFTMMU) 
in hw/Makefile.objs)
18/19 Checking commit 8f48c9a92462 (create_config: remove $(CONFIG_SOFTMMU) 
hack)
19/19 Checking commit db7c8bd2b12b (vl: make sure char-pty message displayed by 
moving setbuf to the beginning)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden