[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/19] memory: unref the memory region in simplify fl
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 09/19] memory: unref the memory region in simplify flatview |
Date: |
Tue, 16 Jul 2019 10:11:07 +0200 |
From: King Wang <address@hidden>
The memory region reference is increased when insert a range
into flatview range array, then decreased by destroy flatview.
If some flat range merged by flatview_simplify, the memory region
reference can not be decreased by destroy flatview any more.
In this case, start virtual machine by the command line:
qemu-system-x86_64
-name guest=ubuntu,debug-threads=on
-machine pc,accel=kvm,usb=off,dump-guest-core=off
-cpu host
-m 16384
-realtime mlock=off
-smp 8,sockets=2,cores=4,threads=1
-object
memory-backend-file,id=ram-node0,prealloc=yes,mem-path=/dev/hugepages,share=yes,size=8589934592
-numa node,nodeid=0,cpus=0-3,memdev=ram-node0
-object
memory-backend-file,id=ram-node1,prealloc=yes,mem-path=/dev/hugepages,share=yes,size=8589934592
-numa node,nodeid=1,cpus=4-7,memdev=ram-node1
-no-user-config
-nodefaults
-rtc base=utc
-no-shutdown
-boot strict=on
-device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2
-device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x2
-device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x3
-drive
file=ubuntu.qcow2,format=qcow2,if=none,id=drive-virtio-disk0,cache=none,aio=native
-device
virtio-blk-pci,scsi=off,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1
-chardev pty,id=charserial0
-device isa-serial,chardev=charserial0,id=serial0
-device usb-tablet,id=input0,bus=usb.0,port=1
-vnc 0.0.0.0:0
-device VGA,id=video0,vgamem_mb=16,bus=pci.0,addr=0x5
-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x6
-msg timestamp=on
And run the script in guest OS:
while true
do
setpci -s 00:06.0 04.b=03
setpci -s 00:06.0 04.b=07
done
I found the reference of node0 HostMemoryBackendFile is a big one.
(gdb) p numa_info[0]->node_memdev->parent.ref
$6 = 1636278
(gdb)
Signed-off-by: King Wang<address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
memory.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 480f3d9..d8d42bd 100644
--- a/memory.c
+++ b/memory.c
@@ -321,7 +321,7 @@ static bool can_merge(FlatRange *r1, FlatRange *r2)
/* Attempt to simplify a view by merging adjacent ranges */
static void flatview_simplify(FlatView *view)
{
- unsigned i, j;
+ unsigned i, j, k;
i = 0;
while (i < view->nr) {
@@ -332,6 +332,9 @@ static void flatview_simplify(FlatView *view)
++j;
}
++i;
+ for (k = i; k < j; k++) {
+ memory_region_unref(view->ranges[k].mr);
+ }
memmove(&view->ranges[i], &view->ranges[j],
(view->nr - j) * sizeof(view->ranges[j]));
view->nr -= j - i;
--
1.8.3.1
- [Qemu-devel] [PULL 01/19] scsi-disk: pass sense correctly for guest-recoverable errors, (continued)
- [Qemu-devel] [PULL 01/19] scsi-disk: pass sense correctly for guest-recoverable errors, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 02/19] scsi: explicitly list guest-recoverable sense codes, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 03/19] scsi: add guest-recoverable ZBC errors, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 04/19] iscsi: fix busy/timeout/task set full, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 05/19] iscsi: base all handling of check condition on scsi_sense_to_errno, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 06/19] build-sys: remove slirp cflags from main-loop.o, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 07/19] rdmacm-mux: fix strcpy string warning, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 08/19] hw/i386: turn off vmport if CONFIG_VMPORT is disabled, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 09/19] memory: unref the memory region in simplify flatview,
Paolo Bonzini <=
- [Qemu-devel] [PULL 10/19] Fix broken build with WHPX enabled, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 11/19] util: merge main-loop.c and iohandler.c, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 12/19] hw/lm32/Kconfig: Milkymist One provides a USB 1.1 Controller, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 14/19] target/i386: sev: Do not unpin ram device memory region, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 15/19] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 16/19] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 13/19] checkpatch: detect doubly-encoded UTF-8, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 17/19] Makefile: do not repeat $(CONFIG_SOFTMMU) in hw/Makefile.objs, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 19/19] vl: make sure char-pty message displayed by moving setbuf to the beginning, Paolo Bonzini, 2019/07/16
- [Qemu-devel] [PULL 18/19] create_config: remove $(CONFIG_SOFTMMU) hack, Paolo Bonzini, 2019/07/16