Re: [Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler

[Alex Bennée]

Jon Doron <address@hidden> writes:

> This patch series refactors the old gdbstub command packets handler
> with a new infrastructure which should ease extending and adding new
> and missing gdb command packets.

And a:

Tested-by: Alex Bennée <address@hidden>

for the whole series. I'll see about preparing a PR next week.

>
> version 12 changes:
> - Fixed a bug during rebase of v10 which broke:
>   "Implement breakpoint commands (Z/z pkt) with new infra"
>   which basically broke the remove breakpoint command
> - Changed gdb_handle_packet call to process_string_cmds with a wrapper
>   which handles errors appropriately.
> - Patches which require review:
>   gdbstub: Implement deatch (D pkt) with new infra
>   gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
>   gdbstub: Implement set register (P pkt) with new infra
>   gdbstub: Implement get register (p pkt) with new infra
>   gdbstub: Implement file io (F pkt) with new infra
>   gdbstub: Implement v commands with new infra
>   gdbstub: Implement generic set/query (Q/q pkt) with new infra
>   gdbstub: Implement target halted (? pkt) with new infra
>   gdbstub: Implement qemu physical memory mode
>
> version 11 changes:
> - Add reviewed by tag
> - Requires review:
>   gdbstub: Implement deatch (D pkt) with new infra
>   gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
>   gdbstub: Implement set register (P pkt) with new infra
>   gdbstub: Implement get register (p pkt) with new infra
>   gdbstub: Implement file io (F pkt) with new infra
>   gdbstub: Implement v commands with new infra
>   gdbstub: Implement generic set/query (Q/q pkt) with new infra
>   gdbstub: Implement target halted (? pkt) with new infra
>   gdbstub: Implement qemu physical memory mode
> - Already reviewed:
>   gdbstub: Add infrastructure to parse cmd packets
>   gdbstub: Implement thread_alive (T pkt) with new infra
>   gdbstub: Implement continue (c pkt) with new infra
>   gdbstub: Implement continue with signal (C pkt) with new infra
>   gdbstub: Implement set_thread (H pkt) with new infra
>   gdbstub: Implement write memory (M pkt) with new infra
>   gdbstub: Implement read memory (m pkt) with new infra
>   gdbstub: Implement write all registers (G pkt) with new infra
>   gdbstub: Implement read all registers (g pkt) with new infra
>   gdbstub: Implement step (s pkt) with new infra
>   gdbstub: Clear unused variables in gdb_handle_packet
>
> version 10 changes:
> - Remove kvm added API as this is not really required and can be
>   accomplished by defining a coprocessor callback with a system
>   specific xml (see: 200bf5b7ffea635079cc05fdfb363372b9544ce7)
> - Remove the new QEMU extended commands to read KVM MSRs
> - Various fixes from Code Review by Alex Bennee
> - Change the QEMU specific command to read physical memory to non-User QEMU
> - Per patch changes:
>   gdbstub: Add infrastructure to parse cmd packets
>     * remove the union for the flags in GdbCmdParseEntry
>   gdbstub: Implement deatch (D pkt) with new infra
>     * Changed default handling for error flow / command not found
>   gdbstub: Implement continue with signal (C pkt) with new infra
>     * Added comment we dont support C sig;[addr] commands
>   gdbstub: Implement set_thread (H pkt) with new infra
>     * Change num_params check to be equal and not less than
>   gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
>     * Merged z/Z commands into a single patch
>   gdbstub: Implement read memory (m pkt) with new infra
>     * Change num_params check to be equal and not less than
>   gdbstub: Implement file io (F pkt) with new infra
>     * Changed to have a single command parser
>   gdbstub: Implement generic set/query (Q/q pkt) with new infra
>     * Merged q/Q and qemu.Supported patches into a single patch
>   gdbstub: Implement target halted (? pkt) with new infra
>     * Removed TODO comment and added a note about it in the commit msg
>   gdbstub: Implement qemu physical memory mode
>     * Added CONFIG_USER_ONLY where required
>
> version 9 changes:
> - checkpatch fixes
>
> version 8 changes:
> - Add new command to display the Supported qemu generic query/sets
> - kvm: Add API to read/write a MSR
> - Add new commands specific for qemu:
>   * Command to swap the memory GDB sees to be the physical memory
>   * Commands to read and write a MSR
>
> version 7 changes:
> - Fixed few checkpatch complaints
> - Feedback from Alex Bennee
>
> version 4-6 changes:
> - mostly feedback from Richard Henderson
>
> version 3 changes
> - Split the single patch to many individual patches for easier reviewing
>
> version 2 changes
> - Code convention fixes
>
> Jon Doron (20):
>   gdbstub: Add infrastructure to parse cmd packets
>   gdbstub: Implement deatch (D pkt) with new infra
>   gdbstub: Implement thread_alive (T pkt) with new infra
>   gdbstub: Implement continue (c pkt) with new infra
>   gdbstub: Implement continue with signal (C pkt) with new infra
>   gdbstub: Implement set_thread (H pkt) with new infra
>   gdbstub: Implement breakpoint commands (Z/z pkt) with new infra
>   gdbstub: Implement set register (P pkt) with new infra
>   gdbstub: Implement get register (p pkt) with new infra
>   gdbstub: Implement write memory (M pkt) with new infra
>   gdbstub: Implement read memory (m pkt) with new infra
>   gdbstub: Implement write all registers (G pkt) with new infra
>   gdbstub: Implement read all registers (g pkt) with new infra
>   gdbstub: Implement file io (F pkt) with new infra
>   gdbstub: Implement step (s pkt) with new infra
>   gdbstub: Implement v commands with new infra
>   gdbstub: Implement generic set/query (Q/q pkt) with new infra
>   gdbstub: Implement target halted (? pkt) with new infra
>   gdbstub: Clear unused variables in gdb_handle_packet
>   gdbstub: Implement qemu physical memory mode
>
>  gdbstub.c | 1761 ++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 1270 insertions(+), 491 deletions(-)


--
Alex Bennée