[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 12/20] gdbstub: Implement write all registers (G
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v12 12/20] gdbstub: Implement write all registers (G pkt) with new infra |
Date: |
Wed, 29 May 2019 09:41:40 +0300 |
Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
gdbstub.c | 41 +++++++++++++++++++++++++++++++----------
1 file changed, 31 insertions(+), 10 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 3d8c2f8f42..a487e549d1 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1751,6 +1751,29 @@ static void handle_read_mem(GdbCmdContext *gdb_ctx, void
*user_ctx)
put_packet(gdb_ctx->s, gdb_ctx->str_buf);
}
+static void handle_write_all_regs(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ target_ulong addr, len;
+ uint8_t *registers;
+ int reg_size;
+
+ if (!gdb_ctx->num_params) {
+ return;
+ }
+
+ cpu_synchronize_state(gdb_ctx->s->g_cpu);
+ registers = gdb_ctx->mem_buf;
+ len = strlen(gdb_ctx->params[0].data) / 2;
+ hextomem(registers, gdb_ctx->params[0].data, len);
+ for (addr = 0; addr < gdb_ctx->s->g_cpu->gdb_num_g_regs && len > 0;
+ addr++) {
+ reg_size = gdb_write_register(gdb_ctx->s->g_cpu, registers, addr);
+ len -= reg_size;
+ registers += reg_size;
+ }
+ put_packet(gdb_ctx->s, "OK");
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1762,7 +1785,6 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
uint8_t mem_buf[MAX_PACKET_LENGTH];
char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
char thread_id[16];
- uint8_t *registers;
target_ulong addr, len;
const GdbCmdParseEntry *cmd_parser = NULL;
@@ -1928,16 +1950,15 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
put_packet(s, buf);
break;
case 'G':
- cpu_synchronize_state(s->g_cpu);
- registers = mem_buf;
- len = strlen(p) / 2;
- hextomem((uint8_t *)registers, p, len);
- for (addr = 0; addr < s->g_cpu->gdb_num_g_regs && len > 0; addr++) {
- reg_size = gdb_write_register(s->g_cpu, registers, addr);
- len -= reg_size;
- registers += reg_size;
+ {
+ static const GdbCmdParseEntry write_all_regs_cmd_desc = {
+ .handler = handle_write_all_regs,
+ .cmd = "G",
+ .cmd_startswith = 1,
+ .schema = "s0"
+ };
+ cmd_parser = &write_all_regs_cmd_desc;
}
- put_packet(s, "OK");
break;
case 'm':
{
--
2.21.0
- [Qemu-devel] [PATCH v12 08/20] gdbstub: Implement set register (P pkt) with new infra, (continued)
- [Qemu-devel] [PATCH v12 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 09/20] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 10/20] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 13/20] gdbstub: Implement read all registers (g pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 14/20] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 12/20] gdbstub: Implement write all registers (G pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v12 16/20] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 19/20] gdbstub: Clear unused variables in gdb_handle_packet, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 18/20] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 20/20] gdbstub: Implement qemu physical memory mode, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 15/20] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/29
- Re: [Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler, Alex Bennée, 2019/05/31