[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 19/20] gdbstub: Clear unused variables in gdb_ha
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v12 19/20] gdbstub: Clear unused variables in gdb_handle_packet |
Date: |
Wed, 29 May 2019 09:41:47 +0300 |
Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
gdbstub.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index a474f2c755..a0ff0017f6 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2284,17 +2284,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx,
void *user_ctx)
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
- const char *p;
- int ch;
- uint8_t mem_buf[MAX_PACKET_LENGTH];
- char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
const GdbCmdParseEntry *cmd_parser = NULL;
trace_gdbstub_io_command(line_buf);
- p = line_buf;
- ch = *p++;
- switch(ch) {
+ switch (line_buf[0]) {
case '!':
put_packet(s, "OK");
break;
@@ -2511,8 +2505,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
break;
default:
/* put empty packet */
- buf[0] = '\0';
- put_packet(s, buf);
+ put_packet(s, "");
break;
}
--
2.21.0
- Re: [Qemu-devel] [PATCH v12 09/20] gdbstub: Implement get register (p pkt) with new infra, (continued)
- [Qemu-devel] [PATCH v12 10/20] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 13/20] gdbstub: Implement read all registers (g pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 14/20] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 12/20] gdbstub: Implement write all registers (G pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 16/20] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 19/20] gdbstub: Clear unused variables in gdb_handle_packet,
Jon Doron <=
- [Qemu-devel] [PATCH v12 18/20] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 17/20] gdbstub: Implement generic set/query (Q/q pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 20/20] gdbstub: Implement qemu physical memory mode, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 15/20] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/29
- Re: [Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler, Alex Bennée, 2019/05/31