qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Headers without multiple inclusion guards


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] Headers without multiple inclusion guards
Date: Wed, 29 May 2019 15:20:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/29/19 2:51 PM, Markus Armbruster wrote:
> Max Filippov <address@hidden> writes:
> 
>> On Tue, May 28, 2019 at 11:12 AM Markus Armbruster <address@hidden> wrote:
>>> target/xtensa/helper.h
>> Intentional.
>>
>>> target/xtensa/overlay_tool.h
>> Unintentional.
>>
>>> target/xtensa/xtensa-isa.h
>> It's a one-liner that includes another header.
> 
> Feels like a bad idea, but it doesn't bother me right now.

I think include/hw/xtensa/xtensa-isa.h is misplaced, it should be in
target/xtensa/xtensa-isa.h, but since disas/xtensa.c includes it, it
ended in include/.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]