[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Headers without multiple inclusion guards
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] Headers without multiple inclusion guards |
Date: |
Wed, 29 May 2019 11:19:20 +0200 |
On Tue, 28 May 2019 20:12:24 +0200
Markus Armbruster <address@hidden> wrote:
> We have a bunch of headers without multiple inclusion guards. Some are
> clearly intentional, some look accidental. Too many for me to find out
> by examining each of them, so I'm asking their maintainers.
>
> Why do I ask? I'd like to mark the intentional ones and fix the
> accidental ones, so they don't flunk "make check-headers" from "[RFC v4
> 0/7] Baby steps towards saner headers" just because they lack multiple
> inclusion guards.
>
> Just in case: what's a multiple inclusion guard? It's
>
> #ifndef UNIQUE_GUARD_SYMBOL_H
> #define UNIQUE_GUARD_SYMBOL_H
> ...
> #endif
>
> with nothing but comments outside the conditional, so that the header
> can safely be included more than once.
>
> I append the alphabetical list of headers without multiple inclusion
> guards (as reported by scripts/clean-header-guards -nv), followed by the
> same list sorted into maintainer buckets. If you're cc'ed, please find
> your bucket(s), and tell me which headers intentionally lack guards.
>
[...]
> virtio-9p
> M: Greg Kurz <address@hidden>
> hw/9pfs/xen-9pfs.h
>
It doesn't seem to be intentional, but probably better to
ask Stefano Stabellini, Paul Durrant or Anthony Perard
since this is a xen-9p header, not virtio-9p.
In the meantime, I'll send a fix for MAINTAINERS.
Cheers,
--
Greg
- Re: [Qemu-devel] Headers without multiple inclusion guards, (continued)
- Re: [Qemu-devel] Headers without multiple inclusion guards, Max Filippov, 2019/05/28
- Re: [Qemu-devel] Headers without multiple inclusion guards, Richard Henderson, 2019/05/28
- Re: [Qemu-devel] Headers without multiple inclusion guards, BALATON Zoltan, 2019/05/28
- Re: [Qemu-devel] Headers without multiple inclusion guards, David Gibson, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Laurent Vivier, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Bastian Koppelmann, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Cornelia Huck, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards,
Greg Kurz <=
- Re: [Qemu-devel] Headers without multiple inclusion guards, Alex Bennée, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Anthony PERARD, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, David Hildenbrand, 2019/05/29
- Re: [Qemu-devel] Headers without multiple inclusion guards, Philippe Mathieu-Daudé, 2019/05/29