[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] i386: EFER vs 32-bit CPU
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] i386: EFER vs 32-bit CPU |
Date: |
Wed, 29 May 2019 13:39:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 29/05/19 13:30, Dr. David Alan Gilbert wrote:
>> Should we add a section for i386, which duplicates efer, or just version_id
>> of the main VMSD should
>> be updated?
>
> You could do:
>
> #ifdef TARGET_X86_64
> VMSTATE_UINT64(env.efer, X86CPU),
> VMSTATE_UINT64(env.star, X86CPU),
> ...
>
> to become:
>
> VMSTATE_UINT64_TEST(env.efer, X86CPU, efer_needed)
> #ifdef TARGET_X86_64
> VMSTATE_UINT64(env.star, X86CPU),
>
>
> and then make efer_needed a function that returns true if
> TARGET_X86_64 or it's a new machine type that knows about whatever
> you're going to do with it.
I prefer adding a subsection for 32-bit, so that EFER is saved/restored
if nonzero.
Paolo
Re: [Qemu-devel] i386: EFER vs 32-bit CPU, Peter Xu, 2019/05/29
Re: [Qemu-devel] i386: EFER vs 32-bit CPU, TeLeMan, 2019/05/30