Re: [Qemu-devel] [PULL 00/10] MIPS queue for May 19th, 2019

[Aleksandar Markovic]

On May 20, 2019 2:11 PM, "Peter Maydell" <address@hidden> wrote:
>
> On Sun, 19 May 2019 at 11:52, Aleksandar Markovic
> <address@hidden> wrote:
> >
> > From: Aleksandar Markovic <address@hidden>
> >
> > The following changes since commit
1b46b4daa6fbf45eddcf77877379a0afac341df9:
> >
> >   Merge remote-tracking branch
'remotes/kraxel/tags/ui-20190517-pull-request' into staging (2019-05-17
17:25:19 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/AMarkovic/qemu tags/mips-queue-may-19-2019
> >
> > for you to fetch changes up to 71074d1d2fae9a0c8dab87c5bb5271a71d6cb7ab:
> >
> >   mips: Decide to map PAGE_EXEC in map_address (2019-05-19 12:11:46
+0200)
> >
> > ----------------------------------------------------------------
> >
> > MIPS queue for May 19th, 2019
> >
> >   * A fix for HelenOS boot hang (related to the flag PAGE_EXEC)
> >   * A set of fixes for emulation of MSA ASE on big endian hosts
> >   * Improved usage of object_initialize() and object_initialize_child()
> >   * Better handling of 'div by zero' cases in MSA ASE
> >
> > ----------------------------------------------------------------
>
> Hi -- I'm afraid this fails to build with clang:
> /home/petmay01/linaro/qemu-for-merges/target/mips/op_helper.c:4536:20:
> error: unused function 'ensure_writable_pages'
> [-Werror,-Wunused-function]
> static inline void ensure_writable_pages(CPUMIPSState *env,
>                    ^
> 1 error generated.
>
> It looks like "target/mips: Fix MSA instructions ST.<B|H|W|D>
> on big endian host" removed the last use of this function
> but didn't remove the now-unused definition.
>
> (clang is pickier than gcc about not allowing unused 'static
> inline' functions -- gcc ignores them anywhere, clang only if
> they're in .h files.)
>

Ughhh... Sorry. I should have had a script for this. I'll send v2 in few
days.

Regards,
Aleksandar

> thanks
> -- PMm
>