Re: [Qemu-devel] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

[Cédric Le Goater]

On 3/25/19 7:52 AM, David Gibson wrote:
> On Mon, Mar 25, 2019 at 07:39:32AM +0100, Cédric Le Goater wrote:
>> On 3/22/19 1:15 AM, David Gibson wrote:
>>> Signed-off-by: David Gibson <address@hidden>
>>
>> There is a printf() we could change below. Anyhow,
> 
> What did you have in mind?

[ ... ] 

This printf could be changed to a error_setg() but it should be in 
another patch.

C.  
 
>>> @@ -9385,8 +9428,9 @@ static int test_opcode_table(opc_handler_t **table, 
>>> int len)
>>>  
>>>  static void fix_opcode_tables(opc_handler_t **ppc_opcodes)
>>>  {
>>> -    if (test_opcode_table(ppc_opcodes, PPC_CPU_OPCODES_LEN) == 0)
>>> +    if (test_opcode_table(ppc_opcodes, PPC_CPU_OPCODES_LEN) == 0) {
>>>          printf("*** WARNING: no opcode defined !\n");
>>> +    }
>>>  }