[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEM
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU |
Date: |
Fri, 15 Mar 2019 13:54:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/15/19 11:42 AM, Philippe Mathieu-Daudé wrote:
> Hi,
>
>>From my previous experience with the tests/ patches, I understood we
> could still send PR that improve testing after soft freeze.
> This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs
> in roms/ and rules to rebuild these roms.
> These roms are useful for the ACPI tests introduced in commits
> 09a274d82f and 503bb0b975a on the arm/virt board.
>
> There is 1 direct change:
>
> 1/ in the root Makefile, the 'make install' rule installs one new file:
> - edk2-licenses.txt
>
> And there are 2 other changes which require user specific action:
>
> 2/ Set the environment variable 'INSTALL_BLOBS', the 'make install' rule
> will install the firmware blobs and the firmware JSON descriptors
>
> 3/ a new 'efi' target rule in roms/Makefile
>
> I'm planning to send a PR for this series but I want to check first if
> there is any issue with the current policy/rules.
>
If this were during -rc2 or -rc3, our goal would be minimizing churn,
and I would lean towards deferral. But for mere softfreeze before -rc0,
and with your justification that this helps downstreams while provably
being independent enough of the main binaries to be low risk, I agree
with the idea of a PR.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable201903, (continued)
- [Qemu-devel] [PATCH v2 03/12] tests/uefi-test-tools/build.sh: work around TianoCore#1607, Laszlo Ersek, 2019/03/13
- [Qemu-devel] [PATCH v2 02/12] roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64, Laszlo Ersek, 2019/03/13
- [Qemu-devel] [PATCH v2 01/12] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh", Laszlo Ersek, 2019/03/13
- Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU, Igor Mammedov, 2019/03/14
- Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU, Michael S. Tsirkin, 2019/03/14
- Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU, Philippe Mathieu-Daudé, 2019/03/15
- Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU, Michael Tokarev, 2019/03/16