Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU

[Laszlo Ersek]

On 03/15/19 17:42, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> From my previous experience with the tests/ patches, I understood we
> could still send PR that improve testing after soft freeze.
> This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs
> in roms/ and rules to rebuild these roms.
> These roms are useful for the ACPI tests introduced in commits
> 09a274d82f and 503bb0b975a on the arm/virt board.
> 
> There is 1 direct change:
> 
> 1/ in the root Makefile, the 'make install' rule installs one new file:
>    - edk2-licenses.txt
> 
> And there are 2 other changes which require user specific action:
> 
> 2/ Set the environment variable 'INSTALL_BLOBS', the 'make install' rule
> will install the firmware blobs and the firmware JSON descriptors

(commenting only on the technical note, not the scheduling / PULL,
because I see other (younger) emails in my INBOX about those:)

"INSTALL_BLOBS" is not a new environment variable or Makefile macro --
the context in the affected patch [1] may not show it, but INSTALL_BLOBS
is preexistent, and some of the hunks modify source code that already
falls under INSTALL_BLOBS's scope (e.g., the mention of the
"edk2-licenses.txt" file).

[1] "Makefile: install the edk2 firmware images and their descriptors"

In fact the commit message refers to "--disable-blobs":

    Decompress and install the edk2 firmware blobs as part of "make
    install", unless blob installation was disabled with configure's
    "--disable-blobs" option.

That's what controls INSTALL_BLOBS. (I was intrigued myself, and had
tracked it down for the commit message.)

Thanks,
Laszlo

> 
> 3/ a new 'efi' target rule in roms/Makefile
> 
> I'm planning to send a PR for this series but I want to check first if
> there is any issue with the current policy/rules.
> 
> Thanks,
> 
> Phil.
> 
> On 3/13/19 10:00 PM, Laszlo Ersek wrote:
>> Repo:   https://github.com/lersek/qemu.git
>> Branch: edk2_build_v2
>>
>> Version 1, that is:
>>   [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU
>>
>> was posted at:
>>   https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02846.html
>>   http://mid.mail-archive.com/address@hidden
>>
>> Updates in v2 are noted on each patch individually, in the Notes
>> section.
>>
> [...]
>>>  .gitignore                            |   1 +
>>>  MAINTAINERS                           |  12 ++++++++
>>>  Makefile                              |  22 +++++++++++---
>>>  configure                             |   1 +
>>>  pc-bios/README                        |   2 +-
>>>  pc-bios/edk2-aarch64-code.fd          | Bin 67108864 -> 0 bytes
>>>  pc-bios/edk2-aarch64-code.fd.xz       | Bin 0 -> 1146804 bytes
>>>  pc-bios/edk2-arm-code.fd              | Bin 67108864 -> 0 bytes
>>>  pc-bios/edk2-arm-code.fd.xz           | Bin 0 -> 1147852 bytes
>>>  pc-bios/edk2-arm-vars.fd              | Bin 67108864 -> 0 bytes
>>>  pc-bios/edk2-arm-vars.fd.xz           | Bin 0 -> 10008 bytes
>>>  pc-bios/edk2-i386-code.fd             | Bin 3653632 -> 0 bytes
>>>  pc-bios/edk2-i386-code.fd.xz          | Bin 0 -> 1674764 bytes
>>>  pc-bios/edk2-i386-secure-code.fd      | Bin 3653632 -> 0 bytes
>>>  pc-bios/edk2-i386-secure-code.fd.xz   | Bin 0 -> 1870024 bytes
>>>  pc-bios/edk2-i386-vars.fd             | Bin 540672 -> 0 bytes
>>>  pc-bios/edk2-i386-vars.fd.xz          | Bin 0 -> 320 bytes
>>>  pc-bios/edk2-x86_64-code.fd           | Bin 3653632 -> 0 bytes
>>>  pc-bios/edk2-x86_64-code.fd.xz        | Bin 0 -> 1655276 bytes
>>>  pc-bios/edk2-x86_64-secure-code.fd    | Bin 3653632 -> 0 bytes
>>>  pc-bios/edk2-x86_64-secure-code.fd.xz | Bin 0 -> 1889024 bytes
>>>  roms/Makefile.edk2                    |  32 +++++++++++++-------
>>>  roms/edk2-build.sh                    |   2 +-
>>>  roms/edk2-funcs.sh                    |   4 +--
>>>  tests/Makefile.include                |   2 +-
>>>  25 files changed, 57 insertions(+), 21 deletions(-)