qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable2


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable201903
Date: Thu, 14 Mar 2019 13:29:18 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/14/19 1:02 PM, Philippe Mathieu-Daudé wrote:
> On 3/13/19 10:00 PM, Laszlo Ersek wrote:
>> Update the roms/edk2 submodule hash from edk2-stable201811 to
>> edk2-stable201903. The release notes are available at
>> <https://github.com/tianocore/edk2/releases/tag/edk2-stable201903>.
>>
>> $ git shortlog edk2-stable201811..edk2-stable201903
> 
> BTW this command output is very appreciated in when updating submodule,
> I think we should enforce this as a default policy.
> 

I like that it lists all commit titles (which is usually helpful when
titles are unique, but not infallible), and find authorship nice but not
as essential; meanwhile, I feel that the shortlog output does a
disservice in that the results are not chronological. If we are going to
enforce anything, would the following output be any more useful, because
it lists things in chronological order, and replaces authorship with
commit ids for less ambiguity on reused subject lines?

$ git log --oneline edk2-stable201811..edk2-stable201903

or even some form of git log --pretty=format:XXXX that includes all your
goals of things to see in a list of commits?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]