Re: [Qemu-devel] [PATCH v2 7/7] target/ppc: introduce vsr64_offset() to simplify get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}()

[Richard Henderson]

On 3/7/19 10:05 AM, Mark Cave-Ayland wrote:
> Now that all VSX registers are stored in host endian order, there is no need
> to go via different accessors depending upon the register number. Instead we
> introduce vsr64_offset() and use it directly from within get_cpu_vsr{l,h}() 
> and
> set_cpu_vsr{l,h}().
> 
> This also allows us to rewrite avr64_offset() and fpr_offset() in terms of the
> new vsr64_offset() function to more clearly express the relationship between 
> the
> VSX, FPR and VMX registers, and also remove vsrl_offset() which is no longer
> required.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/cpu.h                    | 20 ++++++++++----------
>  target/ppc/translate/vsx-impl.inc.c | 34 ++++------------------------------
>  2 files changed, 14 insertions(+), 40 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~