[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Statu
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Status emulation |
Date: |
Thu, 6 Dec 2018 12:17:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
Hi
On 12/4/18 5:27 PM, Alex Williamson wrote:
> Now that the downstream port will virtually negotiate itself to the
> link status of the downstream devie, we can remove this emulation.
s/devie/device
> It's not clear that it was every terribly useful anyway.
>
> Tested-by: Geoffrey McRae <address@hidden>
> Signed-off-by: Alex Williamson <address@hidden>
> ---
> hw/vfio/pci.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 74f9a46b4be0..c0cb1ec28908 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev,
> int pos, uint8_t size,
> QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT),
> ~0);
> vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
> }
> -
> - /* Mark the Link Status bits as emulated to allow virtual
> negotiation */
> - vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
> - pci_get_word(vdev->pdev.config + pos +
> - PCI_EXP_LNKSTA),
> - PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);
Reviewed-by: Eric Auger <address@hidden>
Thanks
Eric
> }
>
> /*
>
>
- [Qemu-devel] [for-4.0 PATCH v3 0/9] pcie: Enhanced link speed and width support, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 4/9] pcie: Add link speed and width fields to PCIESlot, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 6/9] pcie: Allow generic PCIe root port to specify link speed and width, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Status emulation, Alex Williamson, 2018/12/04
- Re: [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Status emulation,
Auger Eric <=
- [Qemu-devel] [for-4.0 PATCH v3 9/9] pcie: Fast PCIe root ports for new machines, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 5/9] pcie: Fill PCIESlot link fields to support higher speeds and widths, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 3/9] qapi: Define PCIe link speed and width properties, Alex Williamson, 2018/12/04