[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-4.0 PATCH v3 9/9] pcie: Fast PCIe root ports for n
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [for-4.0 PATCH v3 9/9] pcie: Fast PCIe root ports for new machines |
Date: |
Thu, 6 Dec 2018 12:22:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
Hi
On 12/4/18 5:27 PM, Alex Williamson wrote:
> Change the default speed and width for new machine types to the
> fastest and widest currently supported. This should be compatible to
> the PCIe 4.0 spec. Pre-QEMU-4.0 machine types remain at 2.5GT/s, x1
> width.
>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Thanks
Eric
> ---
> hw/pci-bridge/gen_pcie_root_port.c | 4 ++--
> include/hw/compat.h | 10 +++++++++-
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci-bridge/gen_pcie_root_port.c
> b/hw/pci-bridge/gen_pcie_root_port.c
> index ca5418a89dd2..9766edb44596 100644
> --- a/hw/pci-bridge/gen_pcie_root_port.c
> +++ b/hw/pci-bridge/gen_pcie_root_port.c
> @@ -125,9 +125,9 @@ static Property gen_rp_props[] = {
> DEFINE_PROP_SIZE("pref64-reserve", GenPCIERootPort,
> res_reserve.mem_pref_64, -1),
> DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
> - speed, PCIE_LINK_SPEED_2_5),
> + speed, PCIE_LINK_SPEED_16),
> DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
> - width, PCIE_LINK_WIDTH_1),
> + width, PCIE_LINK_WIDTH_32),
> DEFINE_PROP_END_OF_LIST()
> };
>
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index 70958328fe7a..702cc62277db 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -2,7 +2,15 @@
> #define HW_COMPAT_H
>
> #define HW_COMPAT_3_1 \
> - /* empty */
> + {\
> + .driver = "pcie-root-port",\
> + .property = "speed",\
> + .value = "2_5",\
> + },{\
> + .driver = "pcie-root-port",\
> + .property = "width",\
> + .value = "1",\
> + },
>
> #define HW_COMPAT_3_0 \
> /* empty */
>
>
- [Qemu-devel] [for-4.0 PATCH v3 0/9] pcie: Enhanced link speed and width support, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 4/9] pcie: Add link speed and width fields to PCIESlot, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 6/9] pcie: Allow generic PCIe root port to specify link speed and width, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Status emulation, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 9/9] pcie: Fast PCIe root ports for new machines, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 5/9] pcie: Fill PCIESlot link fields to support higher speeds and widths, Alex Williamson, 2018/12/04
- [Qemu-devel] [for-4.0 PATCH v3 3/9] qapi: Define PCIe link speed and width properties, Alex Williamson, 2018/12/04