Re: [Qemu-devel] [PATCH v3 14/40] target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)

[Aleksandar Markovic]

> From: Richard Henderson <address@hidden>
> Sent: Thursday, July 19, 2018 9:13 PM
>
> >          case NM_POOL32A7:
> > +        {
> > +            switch ((ctx->opcode >> 3) & 0x07) {
> > +            case NM_POOL32AXF:
> > +                gen_pool32axf_nanomips_insn(env, ctx);
> > +                break;
> > +            }
> > +        }
>
> Bad indentation of a block that need not exist anyway.
>
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>

Outer braces are unnecessary. The switch is missing the default case. This 
switch statement is amended in one of subsequent patches, and at the end it 
contains four cases, but no default case. The missing default should be fixed 
in this patch.