[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret |
Date: |
Tue, 12 Jun 2018 18:42:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes:
> On Tue, Jun 12, 2018 at 02:58:21PM +0200, Markus Armbruster wrote:
>> Legacy -drive supports "password-secret" parameter that isn't
>> available with -blockdev / blockdev-add. That's because we backed out
>> our first try to provide it there due to interface design doubts, in
>> commit 577d8c9a811, v2.9.0.
>>
>> This is the second try. It brings back the parameter, except it's
>> named "key-secret" now.
>>
>> Let's review our reasons for backing out the first try, as stated in
>> the commit message:
>>
>> * BlockdevOptionsRbd member @password-secret isn't actually a
>> password, it's a key generated by Ceph.
>
> I thought about that when I first added password-secret, but felt
> that it is still effectively acting as a password to authenticate
> to the server, and calling it password-secret made it clearer that
> it was related to the authentication phase, and not for example,
> disk encryption.
I feel it's best to stick to the names Ceph uses, and Ceph calls it
"key".
[...]
- [Qemu-devel] [PATCH 14/18] check-block-qdict: Rename qdict_flatten()'s variables for clarity, (continued)
- [Qemu-devel] [PATCH 14/18] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 05/18] block: Fix -blockdev for certain non-string scalars, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 13/18] block-qdict: Simplify qdict_is_list() some, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 09/18] block: Make remaining uses of qobject input visitor more robust, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 17/18] rbd: New parameter auth-client-required, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 16/18] block: Fix -blockdev / blockdev-add for empty objects and arrays, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 08/18] block: Factor out qobject_input_visitor_new_flat_confused(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 04/18] qobject: Move block-specific qdict code to block-qdict.c, Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication, Kevin Wolf, 2018/06/12
- Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication, Kevin Wolf, 2018/06/12