[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header |
Date: |
Tue, 12 Jun 2018 17:02:33 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
> From: Max Reitz <address@hidden>
>
> There are numerous QDict functions that have been introduced for and are
> used only by the block layer. Move their declarations into an own
> header file to reflect that.
>
> While qdict_extract_subqdict() is in fact used outside of the block
> layer (in util/qemu-config.c), it is still a function related very
> closely to how the block layer works with nested QDicts, namely by
> sometimes flattening them. Therefore, its declaration is put into this
> header as well and util/qemu-config.c includes it with a comment stating
> exactly which function it needs.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
> Message-Id: <address@hidden>
> [Copright note tweaked, superfluous includes dropped]
s/Copright/Copyright/
Kevin
- [Qemu-devel] [PATCH 10/18] block-qdict: Simplify qdict_flatten_qdict(), (continued)
- [Qemu-devel] [PATCH 10/18] block-qdict: Simplify qdict_flatten_qdict(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 01/18] rbd: Drop deprecated -drive parameter "filename", Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 15/18] check-block-qdict: Cover flattening of empty lists and dictionaries, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 11/18] block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 02/18] iscsi: Drop deprecated -drive parameter "filename", Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 06/18] block: Fix -drive for certain non-string scalars, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 14/18] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header, Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header,
Kevin Wolf <=
- [Qemu-devel] [PATCH 05/18] block: Fix -blockdev for certain non-string scalars, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 13/18] block-qdict: Simplify qdict_is_list() some, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 09/18] block: Make remaining uses of qobject input visitor more robust, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 17/18] rbd: New parameter auth-client-required, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 16/18] block: Fix -blockdev / blockdev-add for empty objects and arrays, Markus Armbruster, 2018/06/12