qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 03/18] block: Add block-specific QDict header
Date: Tue, 12 Jun 2018 18:40:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
>> From: Max Reitz <address@hidden>
>> 
>> There are numerous QDict functions that have been introduced for and are
>> used only by the block layer.  Move their declarations into an own
>> header file to reflect that.
>> 
>> While qdict_extract_subqdict() is in fact used outside of the block
>> layer (in util/qemu-config.c), it is still a function related very
>> closely to how the block layer works with nested QDicts, namely by
>> sometimes flattening them.  Therefore, its declaration is put into this
>> header as well and util/qemu-config.c includes it with a comment stating
>> exactly which function it needs.
>> 
>> Suggested-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Max Reitz <address@hidden>
>> Message-Id: <address@hidden>
>> [Copright note tweaked, superfluous includes dropped]
>
> s/Copright/Copyright/

Fixing, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]