[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error |
Date: |
Wed, 6 Sep 2017 11:15:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/06/2017 06:51 AM, Juan Quintela wrote:
> So far, we had to free the error after each caller, so just do it
> here. Once there, tls.c was leaking the error.
You mention tls.c,
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/channel.c | 1 -
> migration/migration.c | 10 ++++------
> migration/migration.h | 4 ++--
> migration/socket.c | 1 -
> 4 files changed, 6 insertions(+), 10 deletions(-)
but don't touch it. Am I missing something?
>
> -void migrate_fd_error(MigrationState *s, const Error *error)
> +void migrate_fd_error(MigrationState *s, Error *error)
> {
No comments at definition,
> +++ b/migration/migration.h
> @@ -163,8 +163,8 @@ bool migration_has_all_channels(void);
>
> uint64_t migrate_max_downtime(void);
>
> -void migrate_set_error(MigrationState *s, const Error *error);
> -void migrate_fd_error(MigrationState *s, const Error *error);
> +void migrate_set_error(MigrationState *s, Error *error);
> +void migrate_fd_error(MigrationState *s, Error *error);
or at declaration. That would be worth adding at some point, but this
patch isn't making it worse.
The code looks okay in isolation, so if it is only the commit message
that needs fixing,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", (continued)
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Eric Blake, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Daniel P. Berrange, 2017/09/06
[Qemu-devel] [PATCH v7 03/22] migration: Teach it about G_SOURCE_REMOVE, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 04/22] migration: Add comments to channel functions, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 06/22] migration: Improve migration thread error handling, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 05/22] migration: Create migration_has_all_channels, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error, Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error,
Eric Blake <=
[Qemu-devel] [PATCH v7 09/22] migration: Add multifd capability, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 08/22] qio: Create new qio_channel_{readv, writev}_all, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 11/22] migration: Create x-multifd-group parameter, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 10/22] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 12/22] migration: Create multifd migration threads, Juan Quintela, 2017/09/06
[Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming, Juan Quintela, 2017/09/06