Re: [Qemu-devel] [PATCH v7 08/22] qio: Create new qio_channel_{readv, writev}_all

[Daniel P. Berrange]

On Wed, Sep 06, 2017 at 09:03:40AM -0500, Eric Blake wrote:
> On 09/06/2017 06:51 AM, Juan Quintela wrote:
> > The functions waits until it is able to write the full iov.
> > 
> > Signed-off-by: Juan Quintela <address@hidden>
> > 
> > --
> > 
> > Add tests.
> > 
> > fix reader to check for len == 0.
> > 
> > make reader wait on G_IO_IN (dave)
> > change tests to make sure that all combinations of call work with all 
> > backends
> 
> Since Dan's patch to add qio_channel_readv_all has already landed,
> shouldn't this patch just be rebased to add the tests? Or is it also
> fixing some bugs?

I don't think this patch is needed at all from the QIO pov now - the test
script changes don't add any extra coverage compared to what merged.

IOW, only needs the migration/ bit of the patch

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|