[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions" |
Date: |
Wed, 06 Sep 2017 16:42:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> wrote:
> On 09/06/2017 06:51 AM, Juan Quintela wrote:
>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.
>
> But with no reason why? What bugs are you fixing by reverting this?
I put it on the cover letter. I am investigating *why* it fails on me.
It got the thread handed.
>
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/io/channel.h | 90 ---------------------------------------
>> io/channel.c | 94 -----------------------------------------
>> tests/io-channel-helpers.c | 102
>> +++++++++++++++++++++++++++++++++++++++++----
>> 3 files changed, 93 insertions(+), 193 deletions(-)
>>
>
> Looking ahead, I see 8/22 recreates qio_channel_readv_all (but not
> qio_channel_read_all); how does that differ from this one?
>
> Should you be squashing 1/22 and 8/22 into a single non-revert patch
> that just fixes bugs on top of what is already in the tree?
My plan is to fix whatever is there and see why it is failing.
> Also, have you seen my patches, that also fix bugs in the _all functions?
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html
No, I have to take a look, thanks.
Thanks, Juan.
- [Qemu-devel] [PATCH v7 00/22] Multifd, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 02/22] migration: Create migration_ioc_process_incoming(), Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Eric Blake, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions",
Juan Quintela <=
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Eric Blake, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Daniel P. Berrange, 2017/09/06
- [Qemu-devel] [PATCH v7 03/22] migration: Teach it about G_SOURCE_REMOVE, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 04/22] migration: Add comments to channel functions, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 06/22] migration: Improve migration thread error handling, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 05/22] migration: Create migration_has_all_channels, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error, Juan Quintela, 2017/09/06