Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

[Cornelia Huck]

On Wed, 19 Oct 2016 12:51:37 +0200
Cornelia Huck <address@hidden> wrote:

> On Mon, 10 Oct 2016 13:53:35 +0200
> Paolo Bonzini <address@hidden> wrote:
> 
> > Override start_ioeventfd and stop_ioeventfd to start/stop the
> > whole dataplane logic.  This has some positive side effects:
> > 
> > - no need anymore for virtio_add_queue_aio (i.e. a revert of
> >   commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355)
> > 
> > - no need anymore to switch from generic ioeventfd handlers to
> >   dataplane
> > 
> > It detects some errors better:
> > 
> >     $ qemu-system-x86_64 -object iothread,id=io \
> >           -device virtio-scsi-pci,ioeventfd=off,iothread=io
> >     qemu-system-x86_64: -device virtio-scsi-pci,ioeventfd=off,iothread=io:
> >     ioeventfd is required for iothread
> > 
> > while previously it would have started just fine.
> > 
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> >  hw/scsi/virtio-scsi-dataplane.c | 56 
> > +++++++++++++++++++++++++----------------
> >  hw/scsi/virtio-scsi.c           | 24 ++++++++----------
> >  include/hw/virtio/virtio-scsi.h |  6 ++---
> >  3 files changed, 48 insertions(+), 38 deletions(-)
> 
> Looks good to me as well, but give me some more time before I give an
> R-b.

Reviewed-by: Cornelia Huck <address@hidden>