[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to Vi
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to VirtioBusState |
Date: |
Tue, 18 Oct 2016 19:22:51 +0200 |
On Mon, 10 Oct 2016 13:53:31 +0200
Paolo Bonzini <address@hidden> wrote:
> This simplifies the code and removes the ioeventfd_started
> and ioeventfd_set_started callback. The only difference is
> in how virtio-ccw handles an error---it doesn't disable
> ioeventfd forever anymore. It was the only backend to do
> so, and if desired this behavior should be implemented in
> virtio-bus.c.
I guess this depends on whether we consider failures to be generally
transient or generally permanent. I decided to disable ioeventfd on
failure as I could not think of a transient failure; but in the end, it
does not really matter much, so I'm fine with this change.
>
> Instead of ioeventfd_started, the ioeventfd_assign callback now
> determines whether the virtio bus supports host notifiers.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 2 +-
> hw/s390x/virtio-ccw.c | 21 ---------------------
> hw/s390x/virtio-ccw.h | 1 -
> hw/scsi/virtio-scsi-dataplane.c | 2 +-
> hw/virtio/vhost.c | 2 +-
> hw/virtio/virtio-bus.c | 14 ++++++--------
> hw/virtio/virtio-mmio.c | 18 ------------------
> hw/virtio/virtio-pci.c | 17 -----------------
> hw/virtio/virtio-pci.h | 1 -
> include/hw/virtio/virtio-bus.h | 17 +++++++----------
> 10 files changed, 16 insertions(+), 79 deletions(-)
Nice amount of code deletion :)
Reviewed-by: Cornelia Huck <address@hidden>
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Michael S. Tsirkin, 2016/10/09
- [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 01/13] virtio: disable ioeventfd as early as possible, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 02/13] virtio: move ioeventfd_disabled flag to VirtioBusState, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 04/13] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to VirtioBusState, Paolo Bonzini, 2016/10/10
- Re: [Qemu-devel] [PATCH 03/13] virtio: move ioeventfd_started flag to VirtioBusState,
Cornelia Huck <=
- [Qemu-devel] [PATCH 06/13] virtio-blk: always use dataplane path if ioeventfd is active, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 05/13] virtio: introduce virtio_device_ioeventfd_enabled, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 08/13] Revert "virtio: Introduce virtio_add_queue_aio", Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active, Paolo Bonzini, 2016/10/10