[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal |
Date: |
Wed, 19 Oct 2016 13:26:53 +0200 |
On Mon, 10 Oct 2016 13:53:41 +0200
Paolo Bonzini <address@hidden> wrote:
> This is only called from virtio_bus_set_host_notifier.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v1->v2: rebase after commit a8bba0a ("virtio: Tell the user what went
> wrong when event_notifier_init failed", 2016-09-09)
>
> hw/virtio/virtio-bus.c | 62
> +++++++++++++++++++++-----------------------------
> 1 file changed, 26 insertions(+), 36 deletions(-)
>
> +cleanup_event_notifier:
> + /* Test and clear notifier before after disabling event,
I always stumble over that "before after" :)
> + * in case poll callback didn't have time to run.
> + */
> + virtio_queue_host_notifier_read(notifier);
> + event_notifier_cleanup(notifier);
> + return r;
> }
>
> static char *virtio_bus_get_dev_path(DeviceState *dev)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active, (continued)
- [Qemu-devel] [PATCH 10/13] virtio: remove ioeventfd_disabled altogether, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 12/13] virtio: inline virtio_queue_set_host_notifier_fd_handler, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 11/13] virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd, Paolo Bonzini, 2016/10/10
- [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal, Paolo Bonzini, 2016/10/10
- Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal,
Cornelia Huck <=
- [Qemu-devel] [PATCH 09/13] virtio: remove set_handler argument from set_host_notifier_internal, Paolo Bonzini, 2016/10/10
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Cornelia Huck, 2016/10/18
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Cornelia Huck, 2016/10/19
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Cornelia Huck, 2016/10/19
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Paolo Bonzini, 2016/10/19
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Cornelia Huck, 2016/10/20
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Paolo Bonzini, 2016/10/20
- Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Cornelia Huck, 2016/10/21