Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics

[Emilio G. Cota]

On Mon, Oct 17, 2016 at 09:17:35 +0100, Alex Bennée wrote:
> 
> Emilio G. Cota <address@hidden> writes:
> 
> > On Tue, Oct 11, 2016 at 14:40:26 -0500, Richard Henderson wrote:
> >> Sixth time is the charm, right?  This time I'm certain that it
> >> compiles with centos6, and contains the previously missing update
> >> from Emilio to atomic_add-bench.
> >
> > For patches 03-16 (including the elusive patch 06 for which I reviewed 
> > 1bfe0cdf8
> > from your atomic-4 branch on github):
> >
> >   Reviewed-by: Emilio G. Cota <address@hidden>
> >
> > I just tested the patchset by running concurrencykit's ck_pr regression 
> > test (which
> > tests lock'ed ops) for [guest-on-host bits, all x86] 64-on-64, 32-on-32 and
> > 64-on-32. I ran it with TCG debugging enabled. It passes all tests.
> 
> How odd, did you not see the double temp free for target-arm/translate.c?

My tests were x86-only, for both guest and host:
> > tests lock'ed ops) for [guest-on-host bits, all x86] 64-on-64, 32-on-32 and
                                                ^^^^^^^
Sorry for not being clearer.

I have not tested the ARM bits. I just tested aarch64 and it works, though.

I put the scripts online so that others can easily generate natively the ck_pr
tests. If you have an architecture I don't have access to (e.g. ARM, Alpha),
please send me the resulting tarball (the ck_pr.sh script takes care of 
everything)
and I'll upload it with the others:

  http://braap.org/qemu/ck/

Thanks,

                Emilio