Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 10/17/2016 01:17 AM, Alex Bennée wrote:
>>
>> Emilio G. Cota <address@hidden> writes:
>>
>>> On Tue, Oct 11, 2016 at 14:40:26 -0500, Richard Henderson wrote:
>>>> Sixth time is the charm, right?  This time I'm certain that it
>>>> compiles with centos6, and contains the previously missing update
>>>> from Emilio to atomic_add-bench.
>>>
>>> For patches 03-16 (including the elusive patch 06 for which I reviewed 
>>> 1bfe0cdf8
>>> from your atomic-4 branch on github):
>>>
>>>   Reviewed-by: Emilio G. Cota <address@hidden>
>>>
>>> I just tested the patchset by running concurrencykit's ck_pr regression 
>>> test (which
>>> tests lock'ed ops) for [guest-on-host bits, all x86] 64-on-64, 32-on-32 and
>>> 64-on-32. I ran it with TCG debugging enabled. It passes all tests.
                            ^^^^^^^^^^^^^^^^^^^^^

>>
>> How odd, did you not see the double temp free for target-arm/translate.c?
>
> Free just sets a bit in a bitmap, so a double-free isn't visible without the
> --enable-debug-tcg assertion.
    ^^^^^^^^^^^^^^^^

That's why I was confused, I thought Emilio had it enabled.

--
Alex Bennée