[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/9] target-avr: adding instructions encoding
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 4/9] target-avr: adding instructions encodings |
|
Date: |
Mon, 6 Jun 2016 23:06:27 +0100 |
On 6 June 2016 at 22:38, Richard Henderson <address@hidden> wrote:
> On 06/06/2016 03:37 AM, Michael Rolnik wrote:
>>
>> Signed-off-by: Michael Rolnik <address@hidden>
>> ---
>> target-avr/translate-inst.h | 730
>> ++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 730 insertions(+)
>> create mode 100644 target-avr/translate-inst.h
>
>
> Reviewed-by: Richard Henderson <address@hidden>
>
> Although of course it would be better to have the generator
> and source instead of the generated code.
Yes, definitely. (Especially since the GPL wants the 'preferred form
of the work for making modifications'...)
thanks
-- PMM
[Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions, Michael Rolnik, 2016/06/06
Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions, Peter Maydell, 2016/06/06
[Qemu-devel] [PATCH v4 9/9] target-avr: updating translate.c to use instructions translation, Michael Rolnik, 2016/06/06